Wire Telemetry.MetricCardinalityLimit to Beholder#23084
Open
pkcll wants to merge 5 commits into
Open
Conversation
3 tasks
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
Expose MetricCardinalityLimit in core.toml (default 100,000) and pass it through newBeholderClient and LoopRegistry env config to match common #2225.
pkcll
force-pushed
the
beholder-otel-limit-metric-cardinality
branch
from
af4fd5e to
a43c1b3
Compare
Use new() for int pointers and add t.Parallel() to the test and subtests. Co-authored-by: Cursor <cursoragent@cursor.com>
pkcll
force-pushed
the
beholder-otel-limit-metric-cardinality
branch
from
331b2f2 to
724abfc
Compare
…nalityLimit. Regenerate CONFIG.md, update web resolver and node-validate txtar fixtures, fix core.toml indentation and modernize lint, and tidy submodule go.mod files. Co-authored-by: Cursor <cursoragent@cursor.com>
pkcll
force-pushed
the
beholder-otel-limit-metric-cardinality
branch
from
107f0e8 to
3bbc6a1
Compare
product-security-plaid-production
Bot
requested review from
jmank88 and
kalverra
jmank88
reviewed
Jul 13, 2026
Comment on lines
+187
to
+190
| if b.s.MetricCardinalityLimit == nil { | ||
| return defaultMetricCardinalityLimit | ||
| } | ||
| return *b.s.MetricCardinalityLimit |
Contributor
There was a problem hiding this comment.
We shouldn't have hidden defaults buried in the logic of these method. I'm not sure when that started but it would be better not to perpetuate it.
Suggested change
| if b.s.MetricCardinalityLimit == nil { | |
| return defaultMetricCardinalityLimit | |
| } | |
| return *b.s.MetricCardinalityLimit | |
| return *b.s.MetricCardinalityLimit |
Default comes from core.toml via CoreDefaults(); avoid duplicating it in the accessor per review feedback. Co-authored-by: Cursor <cursoragent@cursor.com>
Use v0.11.2-0.20260713191744-8fc8c4e5fe40 (8fc8c4e5) for metric cardinality limit changes. Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MetricCardinalityLimitto[Telemetry]incore.toml(default 100,000,0disables).telemetryConfig→newBeholderClient→beholder.Config.MetricCardinalityLimit.TelemetryMetricCardinalityLimitinLoopRegistry.Companion to chainlink-common#2225.
Test plan
go test ./core/services/chainlink/... ./plugins/...